Skip to content

Add componentNames field to VolatileCriteria - #658

Closed
Acepresso wants to merge 1 commit into
enterprise-contract:mainfrom
Acepresso:exclude-components-EC-1513
Closed

Acepresso wants to merge 1 commit into
enterprise-contract:mainfrom
Acepresso:exclude-components-EC-1513

Conversation

@Acepresso

@Acepresso Acepresso commented Nov 17, 2025

Copy link
Copy Markdown
Contributor

Adds optional componentNames field to allow filtering volatile config include/exclude rules by component name from ApplicationSnapshot.

Example usage:
  volatileConfig:
    exclude:
      - value: "lint.has_failures" componentNames: ["component1", "component2"]

Ref: https://issues.redhat.com/browse/EC-1513
Assisted-by: Cursor (using claude-4.5-sonnet)

@codecov-commenter

codecov-commenter commented Nov 17, 2025

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.65%. Comparing base (e1d2a37) to head (64199a9).

Files with missing lines Patch % Lines
api/v1alpha1/zz_generated.deepcopy.go 0.00% 8 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##            main    #658      +/-   ##
========================================
- Coverage   0.66%   0.65%   -0.02%     
========================================
  Files          6       6              
  Lines        301     307       +6     
========================================
  Hits           2       2              
- Misses       299     305       +6     
Flag Coverage Δ
api 0.74% <0.00%> (-0.02%) ⬇️
controller 0.00% <ø> (ø)
schema 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
api/v1alpha1/enterprisecontractpolicy_types.go 100.00% <ø> (ø)
api/v1alpha1/zz_generated.deepcopy.go 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Acepresso
Acepresso force-pushed the exclude-components-EC-1513 branch 2 times, most recently from 64199a9 to e0d9dd0 Compare November 18, 2025 15:16
@github-actions github-actions Bot added size: L and removed size: S labels Nov 18, 2025
Add optional componentNames field to allow filtering volatile config
include/exclude rules by component name from ApplicationSnapshot.

Example usage:
```
  volatileConfig:
    exclude:
      - value: "lint.has_failures"
        componentNames: ["component1", "component2"]
```

Ref: https://issues.redhat.com/browse/EC-1513
Assisted-by: Cursor (using claude-4.5-sonnet)
@Acepresso
Acepresso force-pushed the exclude-components-EC-1513 branch from e0d9dd0 to 669e039 Compare November 19, 2025 10:07
@Acepresso Acepresso closed this Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants