Skip to content

cleanup: remove/gitignore mock-agent binary - #88

Merged
nader-ziada merged 1 commit into
mcpchecker:mainfrom
Cali0707:gitignore-functional-agent
Jan 21, 2026
Merged

cleanup: remove/gitignore mock-agent binary#88
nader-ziada merged 1 commit into
mcpchecker:mainfrom
Cali0707:gitignore-functional-agent

Conversation

@Cali0707

@Cali0707 Cali0707 commented Jan 21, 2026

Copy link
Copy Markdown
Contributor

In #71 when we renamed the functional tests from e2e to functional, we missed the gitignore entry. This has resulted in the functional/mock-agent binary getting committed to the repo.

This PR removes that binary and adds the correct gitignore entry

Summary by CodeRabbit

  • Chores
    • Updated repository configuration files.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: Calum Murray <cmurray@redhat.com>
@Cali0707
Cali0707 requested a review from a team January 21, 2026 13:50
@coderabbitai

coderabbitai Bot commented Jan 21, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

A single path replacement in the .gitignore file, changing e2e/mock-agent to functional/mock-agent. No functional changes to codebase behavior or control flow.

Changes

Cohort / File(s) Summary
Configuration
.gitignore
Replaced ignored path from e2e/mock-agent to functional/mock-agent

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~1 minute

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: updating .gitignore to ignore the mock-agent binary in the functional directory, which directly aligns with the PR's primary objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nader-ziada

Copy link
Copy Markdown
Contributor

LGTM

@nader-ziada
nader-ziada merged commit 1b77cda into mcpchecker:main Jan 21, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants